Remove unnecessary guard in refresh history callback #1380
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The function ajaxForm() rejects the fetch promise when the response is not a 200, so we can assume that if the code is being executed a 200 was returned. In the event a 200 is returned, the requests attribute is always a JavaScript Array.
Codecov Report
@@ Coverage Diff @@
## master #1380 +/- ##
==========================================
- Coverage 87.83% 87.64% -0.20%
==========================================
Files 29 29
Lines 1578 1578
Branches 222 222
==========================================
- Hits 1386 1383 -3
- Misses 141 144 +3
Partials 51 51
Continue to review full report at Codecov.
|
Member
|
Makes sense, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function ajaxForm() rejects the fetch promise when the response is
not a 200, so we can assume that if the code is being executed a 200 was
returned.
In the event a 200 is returned, the requests attribute is always a
JavaScript Array.